Skip to content

[Doc] Fix a table of Type Mapping Matrix #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2022

Conversation

javiereguiluz
Copy link
Contributor

@javiereguiluz javiereguiluz commented Jan 22, 2022

Q A
Type improvement
BC Break no
Fixed issues -

Summary

The table at this section -> https://www.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/types.html#mapping-matrix is so complex that the new RST parser will probably never parse it correctly.

In this PR I propose an alternative solution to this ... display the table contents "as is". The result doesn't look perfect, but it doesn't look ugly either, because the original RST contents are very readable.

Closes #3338

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been broken for such a long time I think this is the most pragmatic thing to do.

@derrabus derrabus added this to the 3.3.1 milestone Jan 22, 2022
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recent changes I tried didn't fix the rendering of the table, so I'm fine with this.

@SenseException SenseException merged commit f5a111e into doctrine:3.3.x Jan 23, 2022
@javiereguiluz javiereguiluz deleted the patch-2 branch January 24, 2022 07:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mapping matrix documentation is broken
4 participants