Disable DebugStack logger in the test suite #4680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logger does not provide any value when it comes to diagnosing test failures. The primary assumption behind logging the stack of SQL statements is that their combination may be the root cause of an issue but in 100% of my experience with the test suite it's not true. Furthermore, when it comes to running tests in some new environment (e.g. against a new PHP version), massive test failures are expected but the details provided by the logger just create additional noise.
We may consider removing this logger entirely or moving to another higher-level library (e.g. DoctrineBundle).