Document a non-deprecated way to interact with prepared statements #4673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The example executes the function `fetchAllAssociative` on the Statement object but this object doesn't have this function. Instead, the function should be executed on the returned result set.
The existing example proposes clear-text storage of passwords, which is highly discouraged. Furthermore, such an example sheds a negative light on the Doctrine project if security-conscious developers evaluate whether they should use the library based on the provided examples.
morozov
approved these changes
Jun 16, 2021
SenseException
approved these changes
Jun 16, 2021
|
Thanks @derrabus ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While browsing the documentation I noticed that it still contains code examples with the now-deprecated
Statement::execute()method.This PR attempts to fix that by only showing the preferred way to interact with prepared statements. In order to keep merges easy, the PR contains backports of #4505 and #4502 by @xelan and @Sephster.