Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception on invalid LockMode #4428

Closed
BenMorel opened this issue Nov 12, 2020 · 1 comment · Fixed by #4429
Closed

Throw exception on invalid LockMode #4428

BenMorel opened this issue Nov 12, 2020 · 1 comment · Fixed by #4429
Labels
BC Break Improvement Locking
Milestone
3.0.0

Comments

@BenMorel
Copy link
Contributor

BenMorel commented Nov 12, 2020 •
edited by morozov

Feature Request

Q A
New Feature no
RFC no
BC Break yes

Summary

As mentioned in #4400 (comment), we should throw an exception when passing an invalid LockMode to AbstractPlatform::appendLockHint().
@BenMorel BenMorel mentioned this issue Nov 12, 2020
Merged
@morozov morozov added this to the 3.0.0 milestone Nov 12, 2020
@morozov morozov mentioned this issue Nov 13, 2020
Merged
@morozov morozov linked a pull request Nov 13, 2020 that will close this issue
Throw exception on invalid LockMode #4429
Merged
@morozov morozov closed this as completed Nov 13, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
BC Break Improvement Locking
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Throw exception on invalid LockMode morozov/dbal
2 participants
@morozov @BenMorel