Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The test suite fails on PHP 8 due to introduction of the match keyword #4197

Closed
morozov opened this issue Aug 1, 2020 · 1 comment · Fixed by #4202
Closed

The test suite fails on PHP 8 due to introduction of the match keyword #4197

morozov opened this issue Aug 1, 2020 · 1 comment · Fixed by #4202
Assignees
@morozov
Labels
Blocker PHP Test Suite
Milestone
3.0.0

Comments

@morozov
Copy link
Member

morozov commented Aug 1, 2020

See build #711789103 for example:

1) Doctrine\Tests\DBAL\Connection\ExceptionHandlingTest::testDriverExceptionDuringQueryAcceptsBinaryData
ParseError: syntax error, unexpected token "match", expecting identifier or "static" or "namespace" or "\"
...

The failure is caused by sebastianbergmann/phpunit#4373 which will be released as part of PHPUnit 9.3.
@morozov morozov added this to the 3.0.0 milestone Aug 1, 2020
@morozov morozov changed the title The test suite fails on PHP 8 due to warnings The test suite fails on PHP 8 due to introduction of the match keyword Aug 1, 2020
@morozov morozov mentioned this issue Aug 7, 2020
Closed
@morozov morozov linked a pull request Aug 7, 2020 that will close this issue
Manually merge 2.11.x into 3.0.x #4202
Merged
@morozov morozov closed this as completed Aug 7, 2020
@morozov morozov self-assigned this Aug 7, 2020
@morozov morozov added the PHP label Aug 7, 2020
@yookoala yookoala mentioned this issue Jan 23, 2021
Closed
@dependabot dependabot bot mentioned this issue Mar 18, 2021
Closed
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
Blocker PHP Test Suite
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Manually merge 2.11.x into 3.0.x morozov/dbal
1 participant
@morozov