Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SQL comment hint functionality for custom types #3764

Closed
alcaeus opened this issue Dec 2, 2019 · 2 comments
Closed

Document SQL comment hint functionality for custom types #3764

alcaeus opened this issue Dec 2, 2019 · 2 comments

Comments

@alcaeus
Copy link
Member

alcaeus commented Dec 2, 2019

The custom mapping type documentation does not mention the Type::requiresSQLCommentHint method. A recent change in DoctrineBundle 2.0 removes implicitly marking custom types as commented, instead deferring to the logic that is built into the type itself. However, since this isn't documented in the custom mapping types documentation, many people don't know about this and wonder why their custom types don't work.

For users that rely on implicit commenting in DoctrineBundle we introduced a deprecation layer in 1.11 that tells them to update their type, but users creating new types won't know about this. (see also doctrine/DoctrineBundle#1074 and doctrine/DoctrineBundle#977).

@morozov
Copy link
Member

morozov commented Aug 5, 2022

Irrelevant as of #5512.

@morozov morozov closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Sep 5, 2022

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants