Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VersionAwarePlatformDriver should extend Driver #3746

Closed
morozov opened this issue Nov 25, 2019 · 1 comment · Fixed by #3750
Closed

VersionAwarePlatformDriver should extend Driver #3746

morozov opened this issue Nov 25, 2019 · 1 comment · Fixed by #3750
Assignees
@morozov
Labels
Drivers Improvement Platform Detection
Milestone
3.0.0

Comments

@morozov
Copy link
Member

morozov commented Nov 25, 2019

According to sebastianbergmann/phpunit#3955, the fact that some of our tests mock a combination of Driver and VersionAwarePlatformDriver indicates poor design.

Indeed, in its essence, VersionAwarePlatformDriver is a subtype of Driver, not a separate type and should be defined accordingly.
@morozov morozov added this to the 3.0.0 milestone Nov 25, 2019
@morozov morozov self-assigned this Nov 25, 2019
@morozov morozov mentioned this issue Nov 26, 2019
Merged
@morozov morozov mentioned this issue Nov 28, 2019
Merged
@morozov morozov mentioned this issue Oct 6, 2020
Merged
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Nov 17, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@morozov morozov

Labels
Drivers Improvement Platform Detection
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

VersionAwarePlatformDriver now extends Driver morozov/dbal
1 participant
@morozov