Upgrade fixtures to PHP 8.1 and reverse patches #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
approved these changes
Jul 19, 2022
SenseException
approved these changes
Jul 19, 2022
simPod
approved these changes
Jul 19, 2022
malarzm
approved these changes
Jul 19, 2022
|
@simPod Can you look into that? You're more familiar with the patching system and I'm kinda busy at the moment. 🙁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @simPod
Currently, we keep all test fixtures at our lowest supported PHP language level and maintain patches for testing with higher language levels. This PR proposes to reverse that process: Fixtures are maintained for PHP 8.1 and we patch them for testing lower language levels.
My expectation would be that future PRs become easier to review this way and support for old language levels can be dropped by deleting the corresponding patch eventually.