Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require Null Safe Object operator #255

Merged
merged 2 commits into from Jul 20, 2021
Merged

Require Null Safe Object operator #255

merged 2 commits into from Jul 20, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 18, 2021

Same as we require Null Coalesce operator, this requires Null Safe operator.

@simPod simPod requested a review from a team as a code owner July 18, 2021 09:46
ostrolucky
ostrolucky previously approved these changes Jul 18, 2021
View reviewed changes
@simPod
Copy link
Contributor Author

simPod commented Jul 18, 2021

I wonder if we should create a patch for PHP 8+.

SenseException
SenseException previously approved these changes Jul 18, 2021
View reviewed changes
malarzm
malarzm previously approved these changes Jul 19, 2021
View reviewed changes
Copy link
Member

@malarzm malarzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch for PHP 8+ (and generally for versions) sounds like a good idea 👍

@simPod simPod dismissed stale reviews from malarzm, SenseException, and ostrolucky via 3d2ef9a July 20, 2021 06:56
@simPod
Copy link
Contributor Author

simPod commented Jul 20, 2021

I've included #257 so we can have CI passing. So from me this is it.

@greg0ire greg0ire merged commit f4079ae into doctrine:9.0.x Jul 20, 2021
@greg0ire
Copy link
Member

Thanks @simPod !

@greg0ire greg0ire added this to the 9.0.1 milestone Jul 20, 2021
@greg0ire
Copy link
Member

greg0ire commented Jul 20, 2021 •
edited

Hmmmmm… 🤔 shouldn't this have targeted 10.x ?

@simPod
Copy link
Contributor Author

simPod commented Jul 20, 2021

hmm, maybe 🧐 can we create it?

@simPod simPod deleted the null-safe branch July 21, 2021 06:46
@greg0ire greg0ire mentioned this pull request Jun 22, 2022
Merged
@greg0ire
Copy link
Member

Let's revert this, now that the branch exists. Cc @Ocramius

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ostrolucky ostrolucky ostrolucky approved these changes

@greg0ire greg0ire greg0ire approved these changes

@malarzm malarzm malarzm approved these changes

@SenseException SenseException Awaiting requested review from SenseException

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.0.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@simPod @greg0ire @ostrolucky @SenseException @malarzm