Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stable release of slevomat/coding-standard #140

Closed
alcaeus opened this issue Dec 4, 2019 · 4 comments
Closed

Use stable release of slevomat/coding-standard #140

alcaeus opened this issue Dec 4, 2019 · 4 comments
Milestone

Comments

@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2019

This is a release blocker for 7.0: currently we require a dev-master commit of slevomat/coding-standard. This needs to be changed to a stable release before releasing 7.0.

@alcaeus alcaeus added this to the 7.0.0 milestone Dec 4, 2019
@kukulich
Copy link
Contributor

kukulich commented Dec 4, 2019

I was waiting for new release of PHPCS itself because of arrow functions support. Version 3.5.3 was released today, so I just need to write release notes for Slevomat CS and make the release :) This week for sure.

@alcaeus
Copy link
Member Author

alcaeus commented Dec 4, 2019

No worries - this issue is mainly here to block our automatic release tool: it refuses to create a release for a milestone with open issues. We've previously had to think of it and I'd like to have some insurance. Your release is ready when it's ready, we have some more things to take care of for 7.0 anyways.

@kukulich
Copy link
Contributor

kukulich commented Dec 5, 2019

https://github.com/slevomat/coding-standard/releases/tag/6.0.0

@carusogabriel
Copy link
Contributor

Fixed via #144.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants