Add parameter type declarations #467
Conversation
greg0ire
force-pushed
the
param-type-declarations
branch
2 times, most recently
from
7d60371
to
c20b3c3
Compare
|
We should bump to PHP 7.2 at least, otherwise it's tough for downstream projects to support v1 and v2. |
|
🤔 if I bump to 8.1 I can add more parameter type declarations (some with |
greg0ire
force-pushed
the
param-type-declarations
branch
3 times, most recently
from
3969f58
to
9fd489f
Compare
Yes, then again a PHP-8.1-only version of doctrine/annotations feels a bit pointless given that attributes exist. |
|
If you want to migrate from annotations to attributes, you have to upgrade to PHP 8 first. If you do, you are probably not going to update to PHP 8.0, right? |
|
Anyway, I agree it doesn't make a lot of sense, the thing is, I have to release 2.0 with doctrine/lexer 3 support soon, because that way, I can add support for doctrine/lexer 3 in ORM 2.15. I thought I might as well do this, but if you feel I should just tag 2.0 now, let me know. |
|
I think, the PR does make sense. It's just that I'd bump to PHP 7.2 (to gain parameter type widening) or maybe 7.4 if you like. But not beyond that. |
|
Ok, let's bump to 7.2 then 👍 |
greg0ire
force-pushed
the
param-type-declarations
branch
from
9fd489f
to
1fdda26
Compare
This allows us to simplify some dependencies constraints, and to add parameter type declarations.
greg0ire
force-pushed
the
param-type-declarations
branch
from
1fdda26
to
5ccddc6
Compare
No description provided.