Updating DoctrineMigrationsBundle for Doctrine Migrations 2.0 #228
Conversation
jwage
force-pushed
the
2.0
branch
4 times, most recently
from
f84b4ea
to
74c6db7
Compare
jwage
force-pushed
the
2.0
branch
2 times, most recently
from
c4498b6
to
e5079eb
Compare
jwage
force-pushed
the
2.0
branch
11 times, most recently
from
8c2f5bc
to
41532ba
Compare
jwage
force-pushed
the
2.0
branch
6 times, most recently
from
e224624
to
2f223bb
Compare
jwage
force-pushed
the
2.0
branch
2 times, most recently
from
1f04ba5
to
a7f650d
Compare
jwage
force-pushed
the
2.0
branch
3 times, most recently
from
93f2765
to
b6ac051
Compare
| - 7.1 | ||
| - 7.2 | ||
| - nightly | ||
|
|
||
| cache: | ||
| directories: | ||
| - $HOME/.composer/cache |
There was a problem hiding this comment.
you should cache only $HOME/.composer/cache/files, to avoid invalidating the Travis cache due to changes in the packagist metadata (cached in $HOME/.composer/cache/repo). Packagist changes too often (every few minutes) to avoi this invalidation.
|
|
||
| $configuration->setMigrationsColumnName($container->getParameter('doctrine_migrations.column_name')); | ||
| $configuration->setMigrationsColumnLength($container->getParameter('doctrine_migrations.column_length')); | ||
| $configuration->setMigrationsExecutedAtColumnName($container->getParameter('doctrine_migrations.executed_at_column_name')); |
There was a problem hiding this comment.
these ones should check for an explicit config file, as done for the table name
There was a problem hiding this comment.
I am not sure I understand what you mean. You mean how the others have an if (empty(...)) condition around them? These values in the Configuration class have a default value so it can't work the same way unless you have another thought/idea?
| "symfony/framework-bundle": "~2.7|~3.3|~4.0", | ||
| "php": "^7.1", | ||
| "symfony/framework-bundle": "~3.4|~4.0", | ||
| "doctrine/coding-standard": "^4.0", |
| "doctrine/migrations": "^1.1" | ||
| "doctrine/migrations": "^2.0@dev", | ||
| "phpstan/phpstan": "^0.9.2", | ||
| "phpstan/phpstan-strict-rules": "^0.9" |
| "doctrine/doctrine-bundle": "~1.0", | ||
| "doctrine/migrations": "^1.1" | ||
| "doctrine/migrations": "^2.0@dev", | ||
| "phpstan/phpstan": "^0.9.2", |
| ->scalarNode('column_name')->defaultValue('version')->end() | ||
| ->scalarNode('column_length')->defaultValue(255)->end() | ||
| ->scalarNode('executed_at_column_name')->defaultValue('executed_at')->end() | ||
| ->scalarNode('all_or_nothing')->defaultValue(false)->end() |
There was a problem hiding this comment.
these new settings should be added in the XSD for people using XML config files.
Closes #226