Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default branch is not being switched after a release #448

Open
Ocramius opened this issue Oct 19, 2021 · 5 comments
Open

Default branch is not being switched after a release #448

Ocramius opened this issue Oct 19, 2021 · 5 comments

Comments

@Ocramius
Copy link
Member

Noticed when releasing https://github.com/doctrine/DoctrineMigrationsBundle/milestone/22

As I closed the milestone, the pipeline did run successfully: https://github.com/doctrine/DoctrineMigrationsBundle/runs/3941893625?check_suite_focus=true

The branch for 3.3.x was not created though.

@Ocramius Ocramius added this to the 3.3.0 milestone Oct 19, 2021
@goetas
Copy link
Member

goetas commented Oct 19, 2021

There is some issue with the release tool, it happened the same last week with the migrations library

@greg0ire
Copy link
Member

The step that does the switch was deliberately omitted on some repos, and not on the mongoDB ones, because of different policies regarding what the default branch should be: either the current patch or the next minor.

See doctrine/.github#10

@Ocramius
Copy link
Member Author

Right, but then 3.3.x was still not created.

Not switching default branch => OK
Not having 3.3.x is a bit more confusing, but perhaps you want to do this manually.

If that's the case, this can be closed.

@greg0ire
Copy link
Member

Not having 3.3.x is a bit more confusing, but perhaps you want to do this manually.

I think it would be cool to have the laminas/automatic-releases step split into 2 steps, dunno how easy to do that is.

@Ocramius
Copy link
Member Author

dunno how easy to do that is.

Feasible, just work to be done, and with BC of existing commands in mind.

@goetas goetas removed this from the 3.3.0 milestone Nov 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants