Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove container aware migrations documentation #244

Merged
merged 1 commit into from Nov 25, 2018
Merged

Remove container aware migrations documentation #244

merged 1 commit into from Nov 25, 2018

Conversation

j4nr6n
Copy link
Contributor

@j4nr6n j4nr6n commented Nov 19, 2018

It's not recommended to use services in migrations because they could change or be removed, which could leave your database in an unpredictable state.

In addition, the examples don't work without some extra configuration to register migrations as services, which is also, probably, not a good idea.

See #243 for more information.

It's not recommended to use services in migrations because they could change or be removed, which could leave your database in an unpredictable state.

See #243 for more information.
@alcaeus
Copy link
Member

alcaeus commented Nov 25, 2018

Build failure is unrelated. Thanks @j4nr6n!

@alcaeus alcaeus merged commit 909088f into doctrine:master Nov 25, 2018
@alcaeus alcaeus self-assigned this Nov 25, 2018
@j4nr6n j4nr6n deleted the patch-1 branch November 27, 2018 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants