WIP: Add "Default" group to fixtures that have no group #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnetik
force-pushed
the
group-default
branch
from
1c25a08
to
5bbee66
Compare
SenseException
requested changes
Aug 28, 2019
There was a problem hiding this comment.
Thank you for your contribution. Before we can start a review, there is at least one missing test for your feature you mentioned in #291.
You currently only test doctrine:fixtures:load --group=Default, but not the other use case where you use Default a given fixture group. Please add a test for this case too.
This addition will also need new entries in the documentation.
|
@magnetik any news regarding the missing test here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #291