Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiring of the new PropertyAccessExtractor #965

Merged
merged 1 commit into from May 13, 2019

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented May 12, 2019

Wiring for symfony/symfony#31486.

@alcaeus
Copy link
Member

alcaeus commented May 13, 2019

LGTM. @dunglas can you fix the coding style error?

FILE: DependencyInjection/DoctrineExtension.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 799 | ERROR | [x] Use early exit to reduce code nesting.
     |       |     (SlevomatCodingStandard.ControlStructures.EarlyExit.EarlyExitNotUsed)
--------------------------------------------------------------------------------

@dunglas
Copy link
Contributor Author

dunglas commented May 13, 2019

Actually, for this specific case, it just increases the cyclomatic complexity. But done in another commit.

@alcaeus alcaeus changed the base branch from master to 1.11.x May 13, 2019 10:29
@alcaeus
Copy link
Member

alcaeus commented May 13, 2019

I agree there - this is an edge case in the sniff that I don’t like either. I’ll see if we can update the coding standard or fix the sniff.

@dunglas
Copy link
Contributor Author

dunglas commented May 13, 2019

It has been discussed here: slevomat/coding-standard#371 (comment)

@alcaeus
Copy link
Member

alcaeus commented May 13, 2019

I've changed the base to 1.11, but this is good to go. Thanks for the fix @dunglas!

@alcaeus alcaeus self-assigned this May 13, 2019
@alcaeus alcaeus added the Bug label May 13, 2019
@alcaeus alcaeus added this to the 1.11.1 milestone May 13, 2019
@alcaeus alcaeus merged commit f2a47c0 into doctrine:1.11.x May 13, 2019
@alcaeus alcaeus added this to 1.11 in Roadmap Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants