Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non existent service when using symfony cache pools #964

Merged
merged 1 commit into from May 13, 2019
Merged

Fix non existent service when using symfony cache pools #964

merged 1 commit into from May 13, 2019

Conversation

deguif
Copy link
Contributor

@deguif deguif commented May 12, 2019

Thanks for publishing 1.11.0 version.

When updating to 1.11.0 and simplifying my previous hacky configuration by using the new method for declaring cache configuration based on the symfony cache pools, I got one error.

The service "doctrine.orm.default_entity_manager" has a dependency on a non-existent service "doctrine.orm.cache.pool.my_cache_pool".

By looking at the code, the createPoolCacheDefinition returns a service id, which will be aliased later, but this service id was never registered on the container (instead it was its alias).

I updated the code so that the service id is registered and could later be aliased.

@deguif deguif changed the title Fix service non existent error Fix service non existent error when using symfony cache pools May 12, 2019
@deguif deguif changed the title Fix service non existent error when using symfony cache pools Fix service non existent service when using symfony cache pools May 12, 2019
@deguif deguif changed the title Fix service non existent service when using symfony cache pools Fix non existent service when using symfony cache pools May 12, 2019
@alcaeus
Copy link
Member

alcaeus commented May 12, 2019

Eh, that’s not good. I’ll take a look at the fix tomorrow morning and will publish a bug fix release as well. 👍

@alcaeus alcaeus self-requested a review May 12, 2019 20:19
@alcaeus alcaeus self-assigned this May 12, 2019
@alcaeus alcaeus added the Bug label May 12, 2019
@alcaeus alcaeus added this to the 1.11.1 milestone May 12, 2019
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deguif!

@alcaeus alcaeus merged commit cc3e327 into doctrine:1.11.x May 13, 2019
@deguif
Copy link
Contributor Author

deguif commented May 13, 2019

You're welcome.
Thanks for maintaining doctrine bundle.

@deguif deguif deleted the fix-cache-pool-service branch May 13, 2019 06:48
@alcaeus alcaeus added this to 1.11 in Roadmap Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants