Wire messenger transport factory #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Apr 4, 2019
greg0ire
reviewed
Apr 4, 2019
greg0ire
approved these changes
Apr 5, 2019
fabpot
requested changes
Apr 5, 2019
alcaeus
force-pushed
the
wire-messenger-transport-factory
branch
from
78774ce
to
45817de
Compare
xabbuh
approved these changes
Apr 5, 2019
alcaeus
added
the
⭐️ EUFOSSA Hackathon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #868.
This adds a service for the DoctrineTransportFactory class to the messenger integration config, but doesn't tag it as transport factory. This way, there shouldn't be any errors due to the class not being present in older versions of symfony/messenger.
The tag is then added in DoctrineExtension if the class in question actually exists.
I'm not sure how to best test this since all we're checking is whether the service has a tag; this information is no longer available in the compiled container. Any suggestions?