Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove useless phpdoc #924

Merged
merged 1 commit into from Feb 25, 2019
Merged

remove useless phpdoc #924

merged 1 commit into from Feb 25, 2019

Conversation

OskarStark
Copy link
Contributor

No description provided.

@OskarStark
Copy link
Contributor Author

friendly ping @alcaeus

SenseException
SenseException reviewed Feb 24, 2019
View reviewed changes
Copy link
Member

@SenseException SenseException left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing some useless comments in the phpdocs. Would you mind to remove more with this PR like "initialize the types" in Doctrine\Bundle\DoctrineBundle\ConnectionFactory::initializeTypes()?

@alcaeus alcaeus self-assigned this Feb 25, 2019
@alcaeus
Copy link
Member

alcaeus commented Feb 25, 2019

@SenseException we can do that in a separate PR - introducing our coding standard should hopefully help with that a bit as well.

Thanks @OskarStark!

@alcaeus alcaeus merged commit 00b14f4 into doctrine:master Feb 25, 2019
@alcaeus alcaeus added this to the 1.11.0 milestone Feb 25, 2019
@OskarStark OskarStark deleted the useless-php-doc branch February 25, 2019 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SenseException SenseException SenseException left review comments

@greg0ire greg0ire greg0ire approved these changes

Assignees

@alcaeus alcaeus

Labels
Improvement
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OskarStark @alcaeus @greg0ire @SenseException