Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rewrite defaultTableOptions in sharded or master/slave connections #915

Merged
merged 2 commits into from Feb 3, 2019
Merged

Don't rewrite defaultTableOptions in sharded or master/slave connections #915

merged 2 commits into from Feb 3, 2019

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Feb 3, 2019

Fixes #900. Supersedes #901.

The schema tool always reads defaultTableOptions from the root options, so we may not move it to the global or master sub-array in sharded or master/slave connections.

Spawnrad and others added 2 commits February 3, 2019 10:40
@alcaeus alcaeus added the Bug label Feb 3, 2019
@alcaeus alcaeus added this to the 1.10.2 milestone Feb 3, 2019
@alcaeus alcaeus self-assigned this Feb 3, 2019
@alcaeus alcaeus requested a review from greg0ire February 3, 2019 09:43
@alcaeus alcaeus mentioned this pull request Feb 3, 2019
Closed
@alcaeus alcaeus merged commit 9fbabc9 into doctrine:1.10.x Feb 3, 2019
@alcaeus alcaeus deleted the fix-default-table-option-rewriting branch February 3, 2019 10:04
@alcaeus alcaeus mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees

@alcaeus alcaeus

Labels
Bug
Projects
None yet
Milestone
1.10.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alcaeus @greg0ire @Spawnrad