Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some missing contents to an XML config sample #913

Merged
merged 2 commits into from Feb 6, 2019
Merged

Conversation

javiereguiluz
Copy link
Contributor

In https://symfony.com/doc/current/bundles/DoctrineBundle/configuration.html#doctrine-dbal-configuration you can see that the XML config doesn't show highlighted contents. This PR may fix it.

Resources/doc/configuration.rst Outdated Show resolved Hide resolved
alcaeus
alcaeus previously requested changes Feb 1, 2019
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving @javiereguiluz! Could I ask you to rebase the PR against the 1.10 branch so we can fix the docs for the currently stable version? Thanks!

@javiereguiluz javiereguiluz changed the base branch from master to 1.10.x February 1, 2019 16:53
@javiereguiluz javiereguiluz changed the base branch from 1.10.x to master February 1, 2019 16:53
@alcaeus alcaeus changed the base branch from master to 1.10.x February 3, 2019 11:06
@alcaeus alcaeus closed this Feb 3, 2019
@alcaeus alcaeus reopened this Feb 3, 2019
@alcaeus alcaeus dismissed their stale review February 3, 2019 11:08

Changes made

@alcaeus alcaeus requested a review from xabbuh February 5, 2019 18:52
@alcaeus alcaeus self-assigned this Feb 5, 2019
@alcaeus alcaeus added this to the 1.10.2 milestone Feb 6, 2019
@alcaeus alcaeus merged commit 1f99e66 into 1.10.x Feb 6, 2019
@alcaeus alcaeus deleted the xml-config branch February 6, 2019 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants