New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the value of path option to match the official recipe #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides consistency, here is a good reason to make this change:
bin/console debug:container --parameter kernel.data_dir
2019-01-30T23:45:09+01:00 [error] Error thrown while running command "debug:container --parameter 'kernel.data_dir'". Message: "You have requested a non-existent parameter "kernel.data_dir". Did you mean one of these: "kernel.root_dir", "kernel.cache_dir", "kernel.logs_dir"?"
In ParameterBag.php line 100:
You have requested a non-existent parameter "kernel.data_dir". Did you mean one of these: "kernel.root_dir", "kernel.cache_dir", "kernel.logs_dir"?
Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for improving @javiereguiluz! Could I ask you to rebase the PR against the 1.10 branch so we can fix the docs for the currently stable version? Thanks!
44a912f
to
9c83c4d
Compare
9c83c4d
to
606aa09
Compare
606aa09
to
554641c
Compare
@alcaeus I may have rebased this successfully ... but please double check it. Thanks. |
Thanks @javiereguiluz! |
This problem was spotted by @nicolas-grekas. He suggested to use instead the same value as in the official recipe (https://github.com/symfony/recipes/blob/master/doctrine/doctrine-bundle/1.6/manifest.json). I fully agree with that and I hope you do too. Thanks.