Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples in entity listeners documentation #906

Merged
merged 1 commit into from Feb 3, 2019

Conversation

YetiCGN
Copy link
Contributor

@YetiCGN YetiCGN commented Jan 22, 2019

The code example is weirdly misleading because the same class is attached to the preUpdate event twice. Furthermore, the YAML example is wrong and inconsistent with the XML example. This PR fixes that.

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @YetiCGN! Could I ask you to rebase the PR against the 1.10 branch so we can fix the docs for the currently stable version? Thanks!

@YetiCGN YetiCGN changed the base branch from master to 1.10.x February 1, 2019 07:56
The code example is weirdly misleading because the same class is attached to the `preUpdate` event twice. Furthermore, the YAML example is wrong and inconsistent with the XML example. This PR fixes that.
@YetiCGN
Copy link
Contributor Author

YetiCGN commented Feb 1, 2019

@alcaeus Sure thing!

@alcaeus alcaeus self-assigned this Feb 3, 2019
@alcaeus alcaeus added this to the 1.10.2 milestone Feb 3, 2019
@alcaeus
Copy link
Member

alcaeus commented Feb 3, 2019

Thanks @YetiCGN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants