Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make travis green #882

Merged
merged 1 commit into from Dec 4, 2018
Merged

Make travis green #882

merged 1 commit into from Dec 4, 2018

Conversation

chalasr
Copy link
Contributor

@chalasr chalasr commented Nov 30, 2018

Fixing the build on Symfony 4.1 and adding a build for 4.2.

@chalasr
Copy link
Contributor Author

chalasr commented Nov 30, 2018

Given the maintenance period of the Symfony 2.8 branch ended recently, I suggest to drop support for Symfony 2.x in the next minor (not done in this PR for now, let me now if you agree).

@kimhemsoe kimhemsoe self-assigned this Nov 30, 2018
@kimhemsoe kimhemsoe added this to the 1.10.1 milestone Nov 30, 2018
@alcaeus
Copy link
Member

alcaeus commented Dec 4, 2018

@chalasr I agree, I would also suggest dropping support for PHP < 7.1 as we've started doing in the other Doctrine bundles.

@kimhemsoe kimhemsoe added the Bug label Dec 4, 2018
@kimhemsoe kimhemsoe merged commit 2ba05a5 into doctrine:master Dec 4, 2018
@kimhemsoe
Copy link
Member

@chalasr Thanks

@chalasr chalasr deleted the fix-ci branch December 4, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants