New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception when configuration is used without doctrine/orm nor doctrine/common #881
Fix exception when configuration is used without doctrine/orm nor doctrine/common #881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you please add a test?
Hi @Majkl578. It's done! |
@webnet-fr Just in case GitHub didn't notify you: The unit test fails on Travis. |
Ready? :D |
@kimhemsoe yep! |
@Majkl578 ping :) |
23367df
to
8f33bf5
Compare
I've squashed your commits and rebased on top of 1.10.x so this can go in as bugfix in the next patch release. Thanks for your contribution, @webnet-fr! |
Will you please release I created new symfony 4.2.x project today and I still got this exception. This might be frustrating for new developers. cc @kimhemsoe
|
I'll take time to release 1.10.1 on Monday 👍 |
…common-package Fix exception when configuration is used without doctrine/orm nor doctrine/common
1.10.1 has been released. |
Hi there is a ReflectionException Class Doctrine\Common\Proxy\AbstractProxyFactory does not exist when the
DoctrineBundle
is used withoutdoctrine/common
being installed.Consider this scenario
composer.json
of my project:I install
DoctrineBundle
withrequire doctrine/doctrine-bundle
.I activate
DoctrineBundle
inKernel
. This entails ReflectionException Class Doctrine\Common\Proxy\AbstractProxyFactory does not exist exception.So when people only need
doctrine/dbal
anddoctrine/doctrine-bundle
in theirs projects are forced to installdoctrine/common
just to avoid this exctption.This PR resolves the issue.
Cheers.