Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make some dependencies optional #958

Closed
thewilkybarkid opened this issue May 1, 2019 · 1 comment
Closed

Make some dependencies optional #958

thewilkybarkid opened this issue May 1, 2019 · 1 comment
Assignees

Comments

@thewilkybarkid
Copy link

Looking at the requirements list, it is possible to make a couple of dependencies optional?

@alcaeus
Copy link
Member

alcaeus commented May 2, 2019

This can only happen in 2.0, but has been planned already.

  • doctrine/doctrine-cache-bundle is only needed if doctrine/orm is installed.

With #114 (which I was hoping to add for 1.11) the bundle would also be required when only using DBAL. However, we are deprecating DoctrineCacheBundle (see doctrine/DoctrineCacheBundle#156) and will be dropping the dependency from version of doctrine/doctrine-bundle onwards.

  • jdorn/sql-formatter is used in the web profiler, but symfony/web-profiler-bundle itself is optional. If it isn't installed but the profiler is, will just be a little less pretty?

As per #785, the dependency seems to be essentially dead. I don't want to drop it in a minor release, but the package is going to be dropped in 2.0. If you know any good alternatives that we may add as formatters, please let me know, but it could very well be that we're dropping this entirely for lack of packages.

With regards to packages only needed when using ORM but not with DBAL, we're thinking of splitting this bundle into two distinct bundles for DBAL and ORM, with the latter having a hard dependency on the former. There's some more work to be done in preparation for that, but it would reduce the number of unnecessary (or optional) dependencies.

I will close this issue since both packages are already in the process of being dropped. Thanks for bringing it up!

@alcaeus alcaeus closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants