Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire the validator metadata factory #938

Closed
dunglas opened this issue Mar 31, 2019 · 6 comments
Closed

Wire the validator metadata factory #938

dunglas opened this issue Mar 31, 2019 · 6 comments
Labels
⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Feature
Milestone
1.11.0

Comments

@dunglas
Copy link
Contributor

dunglas commented Mar 31, 2019

This is the missing part for symfony/symfony#27735.
This bundle must register the new metadata loaders.
@dunglas dunglas mentioned this issue Mar 31, 2019
Closed
@alcaeus
Copy link
Member

alcaeus commented Mar 31, 2019

@dunglas I'm sorry, I have no idea what needs to be done here. Can you prepare a pull request or what needs to be done? I'd like to release 1.11 along Symfony 4.3 to provide support for the new features in the Validator and Messenger components, but haven't had time to familiarise myself with them yet.

@alcaeus alcaeus added this to the 1.11.0 milestone Mar 31, 2019
@alcaeus alcaeus added this to 1.11 in Roadmap Mar 31, 2019
@dunglas
Copy link
Contributor Author

dunglas commented Mar 31, 2019 •
edited

Hi @alcaeus, I started #939 but it's not 100% ready yet (not sure if I'll be able to finish it soon as I'll be away for computer for a few weeks starting tomorrow).

@dunglas
Copy link
Contributor Author

dunglas commented Mar 31, 2019 •
edited

Actually, it is now ready and tested (even if adding a functional test would be better).

@alcaeus
Copy link
Member

alcaeus commented Apr 1, 2019

@dunglas thank you so much, I'll take care of the PR and fix up any remaining issues!

@dunglas
Copy link
Contributor Author

dunglas commented Apr 1, 2019

Thank you very much!

@alcaeus
Copy link
Member

alcaeus commented Apr 6, 2019

#939 was merged, closing here.

@alcaeus alcaeus closed this as completed Apr 6, 2019
@alcaeus alcaeus added the ⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming label Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⭐️ EUFOSSA Hackathon https://symfony.com/blog/the-symfony-and-api-platform-hackathon-is-coming Feature
Projects
None yet
Milestone
1.11.0
Development

No branches or pull requests
2 participants
@dunglas @alcaeus