Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide better error when doctrine/orm is missing #919

Merged
merged 1 commit into from Feb 6, 2019

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 5, 2019

Fixes #908.

@xabbuh
Copy link
Member Author

xabbuh commented Feb 5, 2019

The reported error now looks like this:

$ bin/console cache:clear

In Configuration.php line 313:
                                                                             
  The doctrine/orm package is required when the doctrine.orm config is set.

@greg0ire
Copy link
Member

greg0ire commented Feb 5, 2019

Ah the cs-fix failed… @doctrine/doctrinecore I had the same issue today when contributing, checking cs locally is hard, I had to run composer require -n --prefer-dist --dev doctrine/coding-standard:^5.0 (copied that form .travis.yml) to be able to run phpcbf. Is that the right way to do this?

@Majkl578
Copy link
Contributor

Majkl578 commented Feb 5, 2019

@greg0ire That is solved in master, can't be done in 1.10.x due to PHP 5.x compat.

@alcaeus alcaeus self-assigned this Feb 6, 2019
@alcaeus alcaeus added this to the 1.10.2 milestone Feb 6, 2019
@alcaeus
Copy link
Member

alcaeus commented Feb 6, 2019

Thanks @xabbuh!

@alcaeus alcaeus merged commit a7fa6ef into doctrine:1.10.x Feb 6, 2019
@xabbuh xabbuh deleted the issue-908 branch February 6, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants