Unset parameters for sharded databases as well

[cinamo]

Creating a new database for the global database of a sharded configuration fails, because the command tries to connect to the database that doesn't exist yet.

The cause of this is that the dbname, url and path parameters are not unset for sharded databases, while they are unset for 'normal' connections.

[cinamo]

@kimhemsoe The issue is, in the provided test there's no url or path parameter set, which is why that test succeeds. The default Symfony 4 .env configuration uses a url parameter for the global connection, though...

Would you recommend I add a url parameter in the existing test? Or do you have another suggestion maybe? Thanks!

[kimhemsoe]

Yes, a test showing what you are trying to fix would be nice.

[cinamo]

@kimhemsoe Updated a test that fails on the non-fixed version (but it's all dependent on the exact configuration anyway)

[stof]

Do we need the same kind of fix for MasterSlaveConnection too ?

[cinamo]

@stof It seems that case is covered by the default behavior (the connection parameters are taken from master and then reset in the same fashion as a ‘normal’ connection), so I don’t think so.

[xabbuh]

@alcaeus Should this be backported to the 1.10.x branch as it is part of that milestone?

[alcaeus]

@xabbuh Yes - we've had a minor hiccup with the history. I'll fix it today before releasing.