Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing doctrine/common dependency #887

Closed
umulmrum opened this issue Dec 8, 2018 · 2 comments
Closed

Missing doctrine/common dependency #887

umulmrum opened this issue Dec 8, 2018 · 2 comments
Assignees

Comments

@umulmrum
Copy link

umulmrum commented Dec 8, 2018

Hi,

in \Doctrine\Bundle\DoctrineBundle\DependencyInjection\Configuration::getAutoGenerateModes() the class Doctrine\Common\Proxy\AbstractProxyFactory is used, but doctrine/common is not required.
As symfony/doctrine-bridge 4.2 does no longer require common either, it was removed from my project after upgrading and crashed (that project uses DBAL and the debug toolbar collector, but not ORM).

I'm not sure what the best solution is, but maybe one of these:

  • Add the dependency in DoctrineBundle.
  • Check if the class exists and deactivate parts of the bundle if not (not sure if this makes sense, I'm not too familiar with the bundle).
@kimhemsoe
Copy link
Member

Sounds like a dup of #881

@kimhemsoe kimhemsoe self-assigned this Dec 8, 2018
@umulmrum
Copy link
Author

umulmrum commented Dec 8, 2018

Ah yes, I didn't check the open PRs (so not really duplicate, but I'm fine with closing as the problem is already tackled).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants