Fix Symfony 4.2 deprecations, and Travis build #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todo:
See #877 |
dunglas
added a commit
to dunglas/DoctrineBundle
that referenced
this pull request
Nov 15, 2018
dunglas
added a commit
to dunglas/DoctrineBundle
that referenced
this pull request
Nov 15, 2018
nicolas-grekas
approved these changes
Nov 16, 2018
stof
approved these changes
Nov 16, 2018
|
@dunglas Thanks |
Majkl578
reviewed
Nov 18, 2018
| @@ -48,7 +49,9 @@ public function testContainer() | |||
| $this->assertFalse($container->has('doctrine.dbal.default_connection.events.mysqlsessioninit')); | |||
|
|
|||
| if (interface_exists('Symfony\Component\PropertyInfo\PropertyInfoExtractorInterface') && class_exists('Symfony\Bridge\Doctrine\PropertyInfo\DoctrineExtractor')) { | |||
| $this->assertInstanceOf('Doctrine\Common\Persistence\Mapping\ClassMetadataFactory', $container->get('doctrine.orm.default_entity_manager.metadata_factory')); | |||
| if (!interface_exists(PropertyInitializableExtractorInterface::class)) { | |||
chalasr
pushed a commit
to chalasr/DoctrineBundle
that referenced
this pull request
Nov 30, 2018
kimhemsoe
added a commit
that referenced
this pull request
Nov 30, 2018
Port commands for Symfony 4.2 (follows #876)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tests, and improve Symfony 4.2 compat