New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove legacy workarounds for Messenger integration #872
Conversation
@@ -4,17 +4,12 @@ | |||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | |||
<services> | |||
<service id="doctrine.orm.messenger.middleware_factory.transaction" class="Symfony\Bridge\Doctrine\Messenger\DoctrineTransactionMiddlewareFactory" public="false"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks a test:
DoctrineBundle/Tests/DependencyInjection/DoctrineExtensionTest.php
Lines 700 to 701 in d57c1a3
$this->assertNotNull($container->getDefinition('doctrine.orm.messenger.middleware_factory.transaction')); | |
$this->assertNotNull($middlewarePrototype = $container->getDefinition('messenger.middleware.doctrine_transaction_middleware')); |
https://travis-ci.org/doctrine/DoctrineBundle/jobs/448961134
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests fixed thanks for the direct links.
2dea081
to
6efe0cd
Compare
I this ready to be merged? |
On my side: yes :) |
@nicolas-grekas I broke your PR :D Could you please fix the conflict for me? |
6efe0cd
to
612cea7
Compare
No pb, rebased :) |
@nicolas-grekas Thanks |
aligns integration with latest Messenger improvements
Relates to symfony/symfony#29046