Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy workarounds for Messenger integration #872

Merged
merged 1 commit into from Nov 16, 2018

Conversation

nicolas-grekas
Copy link
Member

aligns integration with latest Messenger improvements
Relates to symfony/symfony#29046

@@ -4,17 +4,12 @@
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd">
<services>
<service id="doctrine.orm.messenger.middleware_factory.transaction" class="Symfony\Bridge\Doctrine\Messenger\DoctrineTransactionMiddlewareFactory" public="false">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change breaks a test:

$this->assertNotNull($container->getDefinition('doctrine.orm.messenger.middleware_factory.transaction'));
$this->assertNotNull($middlewarePrototype = $container->getDefinition('messenger.middleware.doctrine_transaction_middleware'));

https://travis-ci.org/doctrine/DoctrineBundle/jobs/448961134

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests fixed thanks for the direct links.

@kimhemsoe
Copy link
Member

I this ready to be merged?

@nicolas-grekas
Copy link
Member Author

On my side: yes :)

@kimhemsoe
Copy link
Member

@nicolas-grekas I broke your PR :D Could you please fix the conflict for me?

@nicolas-grekas
Copy link
Member Author

No pb, rebased :)

@kimhemsoe kimhemsoe merged commit 7d313f4 into doctrine:master Nov 16, 2018
@kimhemsoe
Copy link
Member

@nicolas-grekas Thanks

@nicolas-grekas nicolas-grekas deleted the messenger branch February 1, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants