Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PHP 5.6+only syntax that breaks the Symfony CI #869

Merged
merged 1 commit into from Oct 30, 2018

Conversation

nicolas-grekas
Copy link
Member

Introduced in #855

@stof
Copy link
Member

stof commented Oct 30, 2018

This change was indeed wrong due to the min PHP version supported by the bundle.

@Majkl578
Copy link
Contributor

The commit message is wrong - use function is not 7.1-only syntax, it exists as of 5.6.

@kimhemsoe Can we just drop <7.1 support in master? It's been source of mutliple issues and confusion (last time here, here and here), it's really time.

@nicolas-grekas nicolas-grekas changed the title Fix PHP 7.1-only syntax that breaks the Symfony CI Fix PHP 5.6+only syntax that breaks the Symfony CI Oct 30, 2018
@nicolas-grekas
Copy link
Member Author

Commit message updated.

@kimhemsoe kimhemsoe modified the milestones: 1.10.0, 1.9.2 Oct 30, 2018
@kimhemsoe kimhemsoe merged commit 797b838 into doctrine:master Oct 30, 2018
@kimhemsoe
Copy link
Member

@nicolas-grekas Thanks

@nicolas-grekas nicolas-grekas deleted the fix55 branch October 30, 2018 16:35
@nicolas-grekas
Copy link
Member Author

@kimhemsoe thanks to you. We're back to green :)

@Ocramius
Copy link
Member

Ocramius commented Nov 4, 2018

Folks, this change is invalid: the fact that symfony mocks method_exists within the DoctrineBundle namespaces is already a nightmare.

This needs to be fixed downstream, not here.

@Ocramius
Copy link
Member

Ocramius commented Nov 4, 2018

Hmm, no, my comment was incorrect: this is because of PHP version support.

Sending a patch to finally put a tombstone on it, once and for all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants