DoctrineCommand class extends the deprecated ContainerAwareCommand class

[javiereguiluz]

Spotted while upgrading the Symfony Demo app to 4.2.x-dev:

The "Doctrine\Bundle\DoctrineBundle\Command\DoctrineCommand" class extends 
"Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand" that is
deprecated since Symfony 4.2, use Command instead.

[Ocramius]

Not sure if the inheritance can be removed without this being called a major BC break though...

…

On Thu, 11 Oct 2018, 15:17 Javier Eguiluz, ***@***.***> wrote: Spotted while upgrading the Symfony Demo app to 4.2.x-dev: The "Doctrine\Bundle\DoctrineBundle\Command\DoctrineCommand" class extends "Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand" that is deprecated since Symfony 4.2, use Command instead. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#863>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAJakPHTGfCFgkEDbgC_GGYbFU2vxyYoks5uj0T6gaJpZM4XXhf0> .

[chalasr]

The type change is technically BC breaking, but who injects (or perform instanceof checks on) containeraware commands... DoctrineCommand could still provide the getContainer() and setContainer() methods for a time (forever if we don't want to make them to use true DI at some point), even implement ContainerAwareInterface.

I'd assume the BC break here. It has been done for swiftmailer-bundle in symfony/swiftmailer-bundle#262, I can do the PR in case we agree.

[chalasr]

Fixed in #877