Support user defined repositories #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shine-neko
reviewed
Sep 26, 2018
| use Doctrine\ORM\Mapping\ClassMetadata; | ||
| use Doctrine\ORM\Repository\RepositoryFactory; | ||
| use Psr\Container\ContainerInterface; | ||
| use Symfony\Component\DependencyInjection\Compiler\ServiceLocatorTagPass; | ||
| use Doctrine\Common\Persistence\ObjectRepository; |
Nek-
force-pushed
the
patch-1
branch
2 times, most recently
from
f0dd12e
to
e0649ca
Compare
|
Errors looks not related. |
alcaeus
requested changes
Oct 12, 2018
|
@alcaeus feedback done 😃 |
alcaeus
reviewed
Oct 12, 2018
There was a problem hiding this comment.
Functionality looks good - @kimhemsoe or @Majkl578, could you confirm that checking for ObjectRepository is safe for ORM 2.4?
A verification was done with EntityRepository inheritance. This commit drop it in favor of a check on interface ObjectRepository which allow user to define its own complete repository.
Older versions of PHP does not support the current implementation so I changed it. Also in order to be able to run the test suite with old versions of Doctrine, this change was also required (because the interface differ).
alcaeus
approved these changes
Oct 15, 2018
|
@Nek- Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A verification was done with EntityRepository inheritance. This commit drop it in favor of a check on interface ObjectRepository which allow the user to define its own complete repository.
Closes #856