Apply Doctrine CS v5 #855
Apply Doctrine CS v5 #855
Conversation
| @@ -63,7 +63,7 @@ jobs: | |||
| env: CODING_STANDARDS | |||
| php: 7.1 | |||
| install: | |||
| - travis_retry composer require -n --prefer-dist --dev doctrine/coding-standard:^4.0 | |||
| - travis_retry composer require -n --prefer-dist --dev doctrine/coding-standard:^5.0 | |||
There was a problem hiding this comment.
Is there some reason why we don't require it in the composer.json itself?
There was a problem hiding this comment.
I think it is probably just old and can be updated to match other repos.
There was a problem hiding this comment.
The reason is that DoctrineBundle sadly still supports dead PHP versions.
|
@carusogabriel rebase, and then I'll just merge this 👍 |
|
@Ocramius Should be RTM 👍 |
|
Hmm, still got PHP 5 on this thing, and it is failing. Can you please remove it, and bump the minimum version to 7.1? Yes, it really is time. |
@kimhemsoe planned to do that for 2.0. |
|
@Ocramius I got a running build when I opened this PR: https://travis-ci.org/doctrine/DoctrineBundle/builds/433228829. Maybe we should retry?
See @Majkl578's #855 (comment), as well, I'd go with keeping this PR only related to Coding Standard changes :) |
|
Right, then 🚢 |
| use Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition; | ||
| use Symfony\Component\Config\Definition\Builder\NodeDefinition; | ||
| use Symfony\Component\Config\Definition\Builder\TreeBuilder; | ||
| use Symfony\Component\Config\Definition\ConfigurationInterface; | ||
| use function method_exists; |
There was a problem hiding this comment.
This line breaks the Symfony CI, fixed in #869
No description provided.