Fix deprecation for symfony/config 4.2+ #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
force-pushed
the
fix_deprecation
branch
from
3665568
to
03a9915
Compare
stof
force-pushed
the
fix_deprecation
branch
from
03a9915
to
e711bed
Compare
Majkl578
suggested changes
Sep 26, 2018
| @@ -33,8 +33,14 @@ public function __construct($debug) | |||
| */ | |||
| public function getConfigTreeBuilder() | |||
| { | |||
| $treeBuilder = new TreeBuilder(); | |||
| $rootNode = $treeBuilder->root('doctrine'); | |||
| $treeBuilder = new TreeBuilder('doctrine'); | |||
There was a problem hiding this comment.
Please use use function instead of \.
There was a problem hiding this comment.
not possible: "php": "^5.5.9|^7.0", in composer.json
There was a problem hiding this comment.
Please, put the "new" statement in the "if" (with/without parms).
There is other "new TreeBuilder()" in the file.
There was a problem hiding this comment.
@stof Using \fn directly violates our coding standard so it's invalid. If, due to PHP 5.5 compatibily, use function cannot be used, the function should be kept in fallback mode.
This breaks build: https://travis-ci.org/doctrine/DoctrineBundle/jobs/443601176#L649
|
Thanks @stof and sorry for the spam :) |
mhujer
added a commit
to mhujer/SensioFrameworkExtraBundle
that referenced
this pull request
Nov 30, 2018
Fixed the same way as in doctrine/DoctrineBundle#853
mhujer
added a commit
to mhujer/SensioFrameworkExtraBundle
that referenced
this pull request
Nov 30, 2018
Fixed the same way as in doctrine/DoctrineBundle#853
mhujer
added a commit
to mhujer/JavaScriptErrorHandlerBundle
that referenced
this pull request
Nov 30, 2018
Fixed the same way as in doctrine/DoctrineBundle#853
fabpot
added a commit
to sensiolabs/SensioFrameworkExtraBundle
that referenced
this pull request
Nov 30, 2018
This PR was merged into the 5.2.x-dev branch. Discussion ---------- Fix deprecation for symfony/config 4.2 Fixed the same way as in doctrine/DoctrineBundle#853 Closes #593 Commits ------- 7db9568 Fix deprecation for symfony/config 4.2
weaverryan
added a commit
to symfony/maker-bundle
that referenced
this pull request
Dec 13, 2018
This PR was merged into the 1.0-dev branch. Discussion ---------- Fix deprecation for symfony/config 4.2+ Fix deprecation for symfony/config 4.2 Fixed the same way as in doctrine/DoctrineBundle#853 Commits ------- 560d03c Fix deprecation for symfony/config 4.2+
Doqnach
added a commit
to Doqnach/woohoolabs-yin-bundle
that referenced
this pull request
Dec 17, 2019
qpautrat
pushed a commit
to qpautrat/woohoolabs-yin-bundle
that referenced
this pull request
Dec 17, 2019
* Fixed symfony 4.2 deprecation The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "qp_woohoolabs_yin" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead * [patch-1] Use BC layer for deprecation in symfony/config see symfony/maker-bundle#324 and doctrine/DoctrineBundle#853 Remove the BC layer when bump to next major version.
artem0723
pushed a commit
to artem0723/React-Clothing-Shop
that referenced
this pull request
Aug 27, 2021
Fixed the same way as in doctrine/DoctrineBundle#853
artem0723
added a commit
to artem0723/React-Clothing-Shop
that referenced
this pull request
Aug 27, 2021
This PR was merged into the 5.2.x-dev branch. Discussion ---------- Fix deprecation for symfony/config 4.2 Fixed the same way as in doctrine/DoctrineBundle#853 Closes #593 Commits ------- 7db9568 Fix deprecation for symfony/config 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #851