Fix handling of lazy entity listeners #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas Thanks |
|
@nicolas-grekas Emh.. whops.. was that supposed to be merged with master? |
|
that's a bug fix, so should go on the lowest maintained branch I suppose? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in symfony/symfony#28304 (comment)
When an entity listener is declared as lazy at the definition level (and not at the tag level), then it is registered using the
ContainerAwareEntityListenerResolver::register(). This class in turn usesget_class()to create its internal map.But
get_class()on a lazy-proxy returns the generated class of the proxy - not the class of the listener implementation.Makes sense?