Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on symfony/framework-bundle #842

Closed
hason opened this issue Aug 23, 2018 · 4 comments
Closed

Remove dependency on symfony/framework-bundle #842

hason opened this issue Aug 23, 2018 · 4 comments
Assignees

Comments

@hason
Copy link
Contributor

hason commented Aug 23, 2018

Classes from framework bundle are used only for commands. I think they should be refactored.

@stof
Copy link
Member

stof commented Aug 23, 2018

Well, technically, we also depend on services defined by FrameworkBundle (for the annotation_reader service at least).

But that's true we should work on refactoring these commands. Using DI rather than ContainerAwareCommand might be an option, as they are defined as services anyway. But we need to be careful about what to inject in them, to avoid issues with instantiating services too early that might break if the DB is not available. We should make sure that instantiating the command does not require connecting to the DB (otherwise, bin/console list could break as it needs to instantiate commands to get the details about them)

@chalasr
Copy link
Contributor

chalasr commented Sep 11, 2018

ContainerAwareCommand has been deprecated for 4.2, I'm willing to help avoiding the incoming deprecation notice but I'm not sure what would be the right plan regarding BC. Ideally these commands should be lazy loaded

@chalasr
Copy link
Contributor

chalasr commented Nov 30, 2018

#877 unlocks this for v2.0 (once the BC layer removed and the symfony/console requirement bumped to ^3.4|^4.0).

@kimhemsoe kimhemsoe added this to the 2.0.0 milestone Nov 30, 2018
@alcaeus alcaeus added this to 2.0 in Roadmap Mar 14, 2019
@alcaeus
Copy link
Member

alcaeus commented Apr 6, 2019

After discussing this with @stof, I decided not to drop the dependency on symfony/framework-bundle: the bundle provides base classes like the generic annotation reader as well as the configuration for symfony/cache that is used in #948.

@alcaeus alcaeus closed this as completed Apr 6, 2019
@alcaeus alcaeus self-assigned this Apr 6, 2019
@alcaeus alcaeus removed this from 2.0 in Roadmap Apr 6, 2019
@alcaeus alcaeus removed this from the 2.0.0 milestone Apr 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants