Inject the EntityManager instead of the factory in DoctrineExtractor #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
commented
Jul 3, 2018
|
Dont know the details, but i am guessing this should be merged? |
dunglas
force-pushed
the
pinfo-deprecate-inject-metadata-factory
branch
2 times, most recently
from
0ce1246
to
aeea6ba
Compare
|
Ready for a last review. It should be merged before the release of 4.2, because without this patch DoctrineBundle triggers a deprecation. |
dunglas
force-pushed
the
pinfo-deprecate-inject-metadata-factory
branch
from
aeea6ba
to
71ad41b
Compare
dunglas
force-pushed
the
pinfo-deprecate-inject-metadata-factory
branch
from
4e06f89
to
58c2217
Compare
nicolas-grekas
approved these changes
Nov 15, 2018
|
@dunglas Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows symfony/symfony#27829