Refactor commands to avoid wrong output #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
like in CreateDatabaseDoctrineCommand
like in CreateDoctrineDatabaseCommand
before not output of the dropped database name was given, only the connection name.
stof
reviewed
Jun 22, 2018
| @@ -49,7 +49,12 @@ protected function configure() | |||
| */ | |||
| protected function execute(InputInterface $input, OutputInterface $output) | |||
| { | |||
| $connection = $this->getDoctrineConnection($input->getOption('connection')); | |||
| $connectionName = $input->getOption('connection'); | |||
| if (empty($connectionName) === true) { | |||
There was a problem hiding this comment.
=== true is useless. empty($connectionName) is already a boolean
There was a problem hiding this comment.
tbh I just copy pasted this part from the create command
shall I change this?
|
I also fixed the Code-Quality build, which belongs to this PR. Shall I change them in this or in an extra PR? |
|
Would be happy to get this merged 😄 |
|
Thanks @OskarStark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review commit by commit.
Could be squashed after review into one.
Before:
this is wrong, as my DB is
lunaand my connection isdefaultAfter:
