Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when missing entity mapping #825

Merged
merged 1 commit into from Oct 30, 2018

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Jun 8, 2018

Otherwise you just get an error like

php.CRITICAL: Call to a member function getClassMetadata() on null

@weaverryan

Copy link
Contributor

@weaverryan weaverryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - I really should have done this originally

Repository/ServiceEntityRepository.php Outdated Show resolved Hide resolved
@Tobion Tobion force-pushed the patch-1 branch 2 times, most recently from 297f257 to 81ae1b6 Compare October 28, 2018 22:42
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the style nitpick, this LGTM.

Repository/ServiceEntityRepository.php Outdated Show resolved Hide resolved
Otherwise you just get an error like

> php.CRITICAL: Call to a member function getClassMetadata() on null
@kimhemsoe kimhemsoe added this to the 1.9.2 milestone Oct 30, 2018
@kimhemsoe kimhemsoe self-assigned this Oct 30, 2018
@kimhemsoe kimhemsoe merged commit 0467ef3 into doctrine:master Oct 30, 2018
@kimhemsoe
Copy link
Member

@Tobion Thanks

@Tobion Tobion deleted the patch-1 branch October 30, 2018 23:40
alcaeus added a commit to alcaeus/DoctrineMongoDBBundle that referenced this pull request Nov 30, 2018
alcaeus added a commit to alcaeus/DoctrineMongoDBBundle that referenced this pull request Nov 30, 2018
alcaeus added a commit to alcaeus/DoctrineMongoDBBundle that referenced this pull request Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants