New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message when missing entity mapping #825
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwage
reviewed
Jun 8, 2018
weaverryan
reviewed
Jun 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - I really should have done this originally
Tobion
force-pushed
the
patch-1
branch
2 times, most recently
from
October 28, 2018 22:42
297f257
to
81ae1b6
Compare
alcaeus
reviewed
Oct 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the style nitpick, this LGTM.
Otherwise you just get an error like > php.CRITICAL: Call to a member function getClassMetadata() on null
@Tobion Thanks |
alcaeus
added a commit
to alcaeus/DoctrineMongoDBBundle
that referenced
this pull request
Nov 30, 2018
alcaeus
added a commit
to alcaeus/DoctrineMongoDBBundle
that referenced
this pull request
Nov 30, 2018
alcaeus
added a commit
to alcaeus/DoctrineMongoDBBundle
that referenced
this pull request
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise you just get an error like
@weaverryan