Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to display the result set #110

Closed
schmittjoh opened this issue Sep 7, 2012 · 11 comments
Closed

Allow to display the result set #110

schmittjoh opened this issue Sep 7, 2012 · 11 comments
Assignees

Comments

@schmittjoh
Copy link
Member

Currently, you can "EXPLAIN" queries in the profiler. It would also be nice if you could let it display the result set of the query in the profiler.

@stof
Copy link
Member

stof commented Sep 7, 2012

@beberlei this would require some logging in the ORM. Currently, we only have logging at the DBAL level

@schmittjoh
Copy link
Member Author

Why in the ORM?

@stof
Copy link
Member

stof commented Sep 7, 2012

@schmittjoh because there is no result set mapping in the DBAL.

Or do you mean displaying the result of running the query itself ? This would make things pretty big in the profiler.

@schmittjoh
Copy link
Member Author

I meant the raw results.

On Fri, Sep 7, 2012 at 2:26 PM, Christophe Coevoet <notifications@github.com

wrote:

@schmittjoh https://github.com/schmittjoh because there is no result
set mapping in the DBAL.

Or do you mean displaying the result of running the query itself ? This
would make things pretty big in the profiler.


Reply to this email directly or view it on GitHubhttps://github.com//issues/110#issuecomment-8363767.

@stof
Copy link
Member

stof commented Sep 7, 2012

I see some cases where it might be useful, but I don't see a good way to display them in a readable way when the query returns lots of results.

@bamarni
Copy link
Contributor

bamarni commented Sep 7, 2012

@beberlei this would require some logging in the ORM. Currently, we only have logging at the DBAL level

👍 Wouldn't this also allow to display DQL in the profiler section? I think this would be a great improvement for readability in this section.

@stof
Copy link
Member

stof commented Sep 7, 2012

@bamarni if we have logging in the needed places in the ORM, it could. However, I think it would be confusing to display both the DQL and the SQL in the profiler (we cannot remove SQL as DQL is not always used). But see #109 for a feature requiring the logging in the ORM, as this one does not in fact.

@bamarni
Copy link
Contributor

bamarni commented Sep 7, 2012

@stof: maybe there could be a button to switch from SQL to DQL (if available)? I was not saying to remove the SQL. But DQL can be useful when you just want to get an overview of a query.

@stof
Copy link
Member

stof commented Sep 7, 2012

@bamarni the SQL is logged at the DBAL level. There is no DQL here. And for all queries dones because of the lazy-loading or a findBy call, there is no DQL at all. Anyway, please create a dedicated issue if you want to discuss it as this is not related to showing the results

@dlsniper
Copy link
Contributor

Hi, is this still relevant? By the looks of the discussion it seems that displaying the results isn't really needed and to be honest, there are plenty of dedicated tools that can run SQL queries, like PHPMyAdmin for example.

@kimhemsoe
Copy link
Member

For now i rather want to avoid, if a good PR comes up i may reconsider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants