Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number-aware underscore naming strategy #1059

Merged

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Nov 19, 2019

Fixes #1057: introduces a new naming strategy that avoids the deprecation notice when using a number-unaware underscore naming strategy.

@alcaeus alcaeus added this to the 1.12.0-Beta2 milestone Nov 19, 2019
@alcaeus alcaeus self-assigned this Nov 19, 2019
@alcaeus alcaeus force-pushed the add-underscore-number-aware-naming-strategy branch from 6ed4932 to 10e5336 Compare November 19, 2019 09:27
@alcaeus alcaeus added this to 1.12 in Roadmap Nov 19, 2019
@stof
Copy link
Member

stof commented Nov 19, 2019

I suggest marking the doctrine.orm.naming_strategy.underscore service as deprecated too.

@alcaeus
Copy link
Member Author

alcaeus commented Nov 19, 2019

@stof I was going to wait for people to upgrade to ORM 2.7 before doing that: the naming strategy change is a BC break, so the current underscore naming strategy shouldn't be deprecated if a user is still using ORM 2.6.

@ro0NL
Copy link

ro0NL commented Nov 19, 2019

@alcaeus
Copy link
Member Author

alcaeus commented Nov 19, 2019

@ro0NL thanks for the reminder! New recipes for 1.12 and 2.0 are coming to make use of simplified cache configuration!

@alcaeus alcaeus merged commit a374f3b into doctrine:1.12.x Nov 19, 2019
@alcaeus alcaeus deleted the add-underscore-number-aware-naming-strategy branch November 19, 2019 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Roadmap
1.12 (bug fixes only)
Development

Successfully merging this pull request may close these issues.

Deprecation in UnderscoreNamingStrategy
3 participants