Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown link bug in navbar #1438

Closed
1 task
jcayzac opened this issue Dec 3, 2020 · 5 comments
Closed
1 task

Markdown link bug in navbar #1438

jcayzac opened this issue Dec 3, 2020 · 5 comments

Comments

@jcayzac
Copy link

jcayzac commented Dec 3, 2020

Bug Report

This markdown link:

- [:jp:〉:us:](/ "English")

…has a correct title="English" when used in a page, but has title="〉" when used in the navbar document.

Steps to reproduce

Use the markdown link above in a navbar.

What is current behaviour

The generated link has title="〉".

What is the expected behaviour

The generated link has title="English".

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: macOS Catalina

  • Browser version: Chrome 86

  • Docsify version: 4.11.6

Link for repro

Link for repro

Mention the docsify version in which this bug was not present (if any)

@sy-records
Copy link
Member

I don't understand what you mean, can you create a sandbox or provide a reproducible address?

@jcayzac
Copy link
Author

jcayzac commented Dec 3, 2020

I don't understand what you mean, can you create a sandbox or provide a reproducible address?

The link to the code sandbox is in the issue?

@sy-records
Copy link
Member

sy-records commented Dec 3, 2020

Sorry, I didn't see that you had created.

I feel like it should have been fixed, You can use this to try.

<script src="//docsify-preview.now.sh/lib/docsify.js"></script>

Fixed via #1360

@jcayzac
Copy link
Author

jcayzac commented Dec 3, 2020

Confirmed it's fixed using the same sandbox code https://codesandbox.io/s/magical-faraday-37q2g
Thanks!
I see the fix is several months old: any chance for a new v4 release soon?

@jcayzac jcayzac closed this as completed Dec 3, 2020
@sy-records
Copy link
Member

We will release as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants