Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not prompt to link ORCID if only exporting DOI #5796

Open
denis-yuen opened this issue Jan 25, 2024 · 1 comment
Open

Do not prompt to link ORCID if only exporting DOI #5796

denis-yuen opened this issue Jan 25, 2024 · 1 comment
Assignees
Labels
enhancement gui Issues related to the current GUI. review merged but pending a third party look at whether it makes sense/is working
Milestone

Comments

@denis-yuen
Copy link
Member

denis-yuen commented Jan 25, 2024

Describe the bug
Do not request ORCID linking if user is only requesting a DOI

To Reproduce
Steps to reproduce the behavior:

  1. Go your own equivalent of https://staging.dockstore.org/my-workflows/dockstore.org/denis-yuen/test
  2. Click on a version and "Request DOI"
  3. See error

Expected behavior
Only request orcid link in alarming red if requesting ORCID export.
(Could be blue note as an example)

Screenshots

Screenshot from 2024-01-25 13-48-27

Additional context

[Domain] - https://staging.dockstore.org

Webservice

  • 1.15.0-rc.1

UI

  • 2.12.0-rc.1

Deploy

  • 1.15.0-rc.1

┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 1.15.x
┆Issue Number: DOCK-2506
┆Sprint: 134 - Gulfport
┆Issue Type: Story

@denis-yuen denis-yuen added enhancement gui Issues related to the current GUI. labels Jan 25, 2024
@denis-yuen denis-yuen added this to the 1.15.x milestone Jan 25, 2024
coverbeck added a commit to dockstore/dockstore-ui2 that referenced this issue Apr 4, 2024
@unito-bot unito-bot added the review merged but pending a third party look at whether it makes sense/is working label Apr 4, 2024
@unito-bot
Copy link

➤ Charles Overbeck commented:

Note: this was merged to hotfix branch and needs to be verified in staging or prod after the next deploy there, the deploy after 1.15.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement gui Issues related to the current GUI. review merged but pending a third party look at whether it makes sense/is working
Projects
None yet
Development

No branches or pull requests

3 participants