Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not found" entry page needs adjustment #5785

Closed
svonworl opened this issue Jan 12, 2024 · 2 comments
Closed

"Not found" entry page needs adjustment #5785

svonworl opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
bug gui Issues related to the current GUI.
Milestone

Comments

@svonworl
Copy link
Contributor

svonworl commented Jan 12, 2024

Describe the bug
When you navigate to the public URL of an existing Dockstore entry that is no longer published, Dockstore displays some "could not be found" content. This content needs some fixin':

  1. The correct entry type should be displayed. For example, in the screenshot below, "workflow" should be "notebook".
  2. The links appear to be malformed/wrong.
  3. Arguably, if I have access to the entry's private page, I should be redirected there, instead.

There could be other issues.

It should be noted that I found the bug when clicking on the link on my profile page, to one of my own notebooks. In lieu of the above redirect, perhaps, when, I’m viewing my own profile, the entry links should be to the private entry page?

Inspect for the various entry types, devise solutions, and implement them.

To Reproduce
Steps to reproduce the behavior:

  1. Enter the public URL of a Dockstore entry that exists, but is not published.
  2. See the bugs.

Expected behavior
Correct information is displayed, and the redirection mentioned above happens.

Screenshots

width=200,height=183

Additional context
[Domain] - https://qa.dockstore.org

Webservice

UI

  • 2.12.0-beta.0-14-g6251a483

Deploy

  • 1.14.4-62-gef77999

cwlParsingLambdaVersion: n/a

wdlParsingLambdaVersion: n/a

nextflowParsingLambdaVersion: n/a

galaxyParsingLambdaVersion: 0.0.6

checkUrlLambdaVersion: n/a

┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 1.16
┆Issue Number: DOCK-2499
┆Sprint: 137 - Jacksonville
┆Issue Type: Story

@svonworl svonworl added bug gui Issues related to the current GUI. labels Jan 12, 2024
@denis-yuen denis-yuen added this to the 1.16 milestone Jan 12, 2024
@denis-yuen
Copy link
Member

See also #5728

@unito-bot
Copy link

➤ Steve Von Worley commented:

When I tried to reproduce these problems, I noticed that the “not found” page had changed since this ticket was written. The new text is good, generic, and doesn’t contain links. So, most of the proposed work is no longer applicable.

This ticket proposes that “Arguably, if I have access to the entry's private page, I should be redirected there, instead.” After consideration, although that would be neat, it’s a relatively edge case and the benefit would not be worth the cost.

While testing, I thought that I’d spotted another issue, but I couldn’t reproduce it later. It’s possible that I was testing on the wrong server (staging or prod versus qa).

So, there is nothing left to do.

Rejecting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gui Issues related to the current GUI.
Projects
None yet
Development

No branches or pull requests

4 participants