Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a version update fails due to a rate limit error, you can't update the version through the UI #5718

Open
coverbeck opened this issue Oct 25, 2023 · 1 comment
Labels
bug gui Issues related to the current GUI. web-service
Milestone

Comments

@coverbeck
Copy link
Contributor

coverbeck commented Oct 25, 2023

Describe the bug
See discussion at https://discuss.dockstore.org/t/message-this-version-has-no-files-of-this-type-upon-refresh-but-valid-file-exists/7679, but it looks like what happened was (implementer should verify):

  1. Non .dockstore.yml workflow
  2. User clicked button to refresh the workflow
  3. A GitHub rate limit error happened while processing the refresh. It's unclear why; my theory is that they tried to refresh several times.
  4. We wrote out the commit of the version processed, but no source file content (because of the error fetching the content due to the GitHub rate limit)
  5. After the rate limit was "restored", the user tried refreshing again, but because the webservice saw it had already processed the commit, it skipped and didn't read anything from GitHub; file stayed with no content.
  6. The user was able to refresh the version using the hardRefresh=true query parameter

To Reproduce
Steps to reproduce the behavior:
See Discourse topic and description

Expected behavior
Ideas:

  1. Don't write out the commit if we get a rate limit error; have better indications in general for this error case.
  2. Expose hardRefresh query parameter in the UI. Perhaps only for versions, and not the workflow, as it can result in a ton of API requests for some workflows.

Additional context
[Domain] - https://dockstore.org

Webservice

  • 1.14.2

UI

  • 2.11.1

Compose Setup

  • 1.14

Deploy

  • 1.14.1

┆Issue is synchronized with this Jira Story
┆Fix Versions: Dockstore 2.X
┆Issue Number: DOCK-2479
┆Sprint: Backlog
┆Issue Type: Story

@coverbeck coverbeck added bug web-service gui Issues related to the current GUI. labels Oct 25, 2023
@coverbeck
Copy link
Contributor Author

Given that this deprecated path for registering workflows, it may not be worth the effort. But we should also make sure this doesn't happen in the .dockstore.yml path -- even though we haven't had any rate limit errors there yet, it could happen eventually.

@coverbeck coverbeck added this to the 1.16 milestone Oct 31, 2023
@denis-yuen denis-yuen modified the milestones: 1.16, 2.X Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug gui Issues related to the current GUI. web-service
Projects
None yet
Development

No branches or pull requests

2 participants