From d5b70f51d84fa5a4a8ad189a55c268f4424e1626 Mon Sep 17 00:00:00 2001 From: CrazyMax Date: Tue, 29 Jun 2021 14:02:42 +0200 Subject: [PATCH] Fix `docker: invalid reference format` Signed-off-by: CrazyMax --- __tests__/buildx.test.ts | 4 ++-- dist/index.js | 10 +++++----- src/buildx.ts | 10 +++++----- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/__tests__/buildx.test.ts b/__tests__/buildx.test.ts index 9b98f87a..b6e4a852 100644 --- a/__tests__/buildx.test.ts +++ b/__tests__/buildx.test.ts @@ -23,7 +23,7 @@ describe('getVersion', () => { silent: true }) .then(res => { - return !res.stdout.includes(' ') && res.exitCode == 0; + return !res.stdout.trim().includes(' ') && res.exitCode == 0; }); } (isDaemonRunning() ? it : it.skip)( @@ -55,7 +55,7 @@ describe('inspect', () => { silent: true }) .then(res => { - return !res.stdout.includes(' ') && res.exitCode == 0; + return !res.stdout.trim().includes(' ') && res.exitCode == 0; }); } (isDaemonRunning() ? it : it.skip)( diff --git a/dist/index.js b/dist/index.js index b8009f42..745e1388 100644 --- a/dist/index.js +++ b/dist/index.js @@ -72,7 +72,7 @@ function getVersion() { if (res.stderr.length > 0 && res.exitCode != 0) { throw new Error(res.stderr.trim()); } - return parseVersion(res.stdout); + return parseVersion(res.stdout.trim()); }); }); } @@ -227,24 +227,24 @@ function getBuildKitVersion(containerID) { .then(bkitimage => { if (bkitimage.exitCode == 0 && bkitimage.stdout.length > 0) { return exec - .getExecOutput(`docker`, ['run', '--rm', bkitimage.stdout, '--version'], { + .getExecOutput(`docker`, ['run', '--rm', bkitimage.stdout.trim(), '--version'], { ignoreReturnCode: true, silent: true }) .then(bkitversion => { if (bkitversion.exitCode == 0 && bkitversion.stdout.length > 0) { - return `${bkitimage.stdout} => ${bkitversion.stdout}`; + return `${bkitimage.stdout.trim()} => ${bkitversion.stdout.trim()}`; } else if (bkitversion.stderr.length > 0) { core.warning(bkitversion.stderr.trim()); } - return bkitversion.stdout; + return bkitversion.stdout.trim(); }); } else if (bkitimage.stderr.length > 0) { core.warning(bkitimage.stderr.trim()); } - return bkitimage.stdout; + return bkitimage.stdout.trim(); }); }); } diff --git a/src/buildx.ts b/src/buildx.ts index d3045c5b..7c2152f8 100644 --- a/src/buildx.ts +++ b/src/buildx.ts @@ -42,7 +42,7 @@ export async function getVersion(): Promise { if (res.stderr.length > 0 && res.exitCode != 0) { throw new Error(res.stderr.trim()); } - return parseVersion(res.stdout); + return parseVersion(res.stdout.trim()); }); } @@ -196,21 +196,21 @@ export async function getBuildKitVersion(containerID: string): Promise { .then(bkitimage => { if (bkitimage.exitCode == 0 && bkitimage.stdout.length > 0) { return exec - .getExecOutput(`docker`, ['run', '--rm', bkitimage.stdout, '--version'], { + .getExecOutput(`docker`, ['run', '--rm', bkitimage.stdout.trim(), '--version'], { ignoreReturnCode: true, silent: true }) .then(bkitversion => { if (bkitversion.exitCode == 0 && bkitversion.stdout.length > 0) { - return `${bkitimage.stdout} => ${bkitversion.stdout}`; + return `${bkitimage.stdout.trim()} => ${bkitversion.stdout.trim()}`; } else if (bkitversion.stderr.length > 0) { core.warning(bkitversion.stderr.trim()); } - return bkitversion.stdout; + return bkitversion.stdout.trim(); }); } else if (bkitimage.stderr.length > 0) { core.warning(bkitimage.stderr.trim()); } - return bkitimage.stdout; + return bkitimage.stdout.trim(); }); }