Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert BuildKit step log limits tweak #50

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Jan 5, 2021

Looks like there is an issue with #46. Log is always clipped even if the size is far from exceeding the current value (8MB):

#10 [linux/amd64 base 3/4] RUN wget -qO- https://github.com/goreleaser/goreleaser/releases/download/v0.149.0/goreleaser_Linux_x86_64.tar.gz | tar -zxvf - goreleaser   && mv goreleaser /usr/local/bin/goreleaser
#10 sha256:818465efb7410f63f04e4cff30dbf041fc97c0340568bc3381f0011d6be40efd
#10 0.197 
#10 0.197 [output clipped, log limit 8MiB reached]
#10 DONE 0.9s

Try to disable clipping but same behavior:

#9 [linux/amd64 base 2/4] RUN apk add --no-cache ca-certificates curl gcc file git musl-dev tar
#9 sha256:cb8a83450b2611af815f803a662bac9437cdf58fe7d6996fbcb878856c7a612c
#9 0.087 
#9 0.087 [output clipped, log limit -1B reached]
#9 DONE 9.1s

Revert #46 in the meantime. cc @tonistiigi

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #50 (8f7787f) into master (87e1457) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   77.27%   77.27%           
=======================================
  Files           5        5           
  Lines         110      110           
  Branches       19       19           
=======================================
  Hits           85       85           
  Misses         18       18           
  Partials        7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87e1457...8f7787f. Read the comment docs.

Verified

This commit was signed with the committer’s verified signature.
crazy-max CrazyMax
This reverts commit 87e1457, reversing
changes made to 370507b.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title Disable clipping Revert BuildKit step log limits tweak Jan 5, 2021
@crazy-max crazy-max merged commit 154c24e into docker:master Jan 5, 2021
@crazy-max crazy-max deleted the disable-clipping branch January 5, 2021 12:39
@tonistiigi
Copy link
Member

Yeah, looks like value set to -1 in some combinations does not work correctly. A big number should work afaics.

@crazy-max
Copy link
Member Author

@tonistiigi Do I open an issue on buildkit repo about that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants